Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/#/c/7808/1/src/host/virt_phy/src/logging.c
File src/host/virt_phy/src/logging.c:

Line 64:         "L1CTL_DATA_TBF_CONF"
it's probably a good time to convert this to value_string.  Having an array 
with *implicit* index is really error-prone and should be avoided.


-- 
To view, visit https://gerrit.osmocom.org/7808
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I442305c034bbba5eaed080fb262a61895623eb4f
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to