Patch Set 1: Code-Review-1

(1 comment)
File src/libbsc/bsc_subscr_conn_fsm.c:

Line 244:       if (!voice) {
I think this is inverted logic here.  "voice" parameter should indicate if it 
is a voice assingment (true) or not (false).  But you're now checking if it's 
*not* a voice assignment, and then add speech codec related bits in such cases?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I316ebcb1f27b668e17fe48fff028e047aac47f76
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <>
Gerrit-Reviewer: Harald Welte <>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes

Reply via email to