Harald Welte has submitted this change and it was merged.
Change subject: flush paging when RSL link is dropped
......................................................................
flush paging when RSL link is dropped
Flush the paging queue if the link to TRX 0 is dropped from a BTS.
This should prevent stale paging requests sent to the BTS when it
disconnects or reconnects, as seen in the TTCN3 BSC_Tests test suite.
Also, add entries to the log when RSL or OML links are dropped so
that related error messages in the log can be interpreted in context.
Change-Id: If4401c1139cd01faf5ff374301a9a701898c3777
Related: OS#2901
---
M src/libbsc/bts_ipaccess_nanobts.c
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
dexter: Looks good to me, but someone else must approve
Neels Hofmeyr: Looks good to me, approved
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libbsc/bts_ipaccess_nanobts.c
b/src/libbsc/bts_ipaccess_nanobts.c
index 4f1ac4b..d94a878 100644
--- a/src/libbsc/bts_ipaccess_nanobts.c
+++ b/src/libbsc/bts_ipaccess_nanobts.c
@@ -41,6 +41,7 @@
#include <osmocom/core/logging.h>
#include <osmocom/bsc/ipaccess.h>
#include <osmocom/bsc/bts_ipaccess_nanobts_omlattr.h>
+#include <osmocom/bsc/paging.h>
extern struct gsm_network *bsc_gsmnet;
@@ -357,8 +358,12 @@
if (!trx->rsl_link)
return;
+ LOGP(DLINP, LOGL_NOTICE, "(bts=%d,trx=%d) Dropping RSL link.\n",
trx->bts->nr, trx->nr);
e1inp_sign_link_destroy(trx->rsl_link);
trx->rsl_link = NULL;
+
+ if (trx->bts->c0 == trx)
+ paging_flush_bts(trx->bts, NULL);
}
void ipaccess_drop_oml(struct gsm_bts *bts)
@@ -369,6 +374,7 @@
if (!bts->oml_link)
return;
+ LOGP(DLINP, LOGL_NOTICE, "(bts=%d) Dropping OML link.\n", bts->nr);
e1inp_sign_link_destroy(bts->oml_link);
bts->oml_link = NULL;
bts->uptime = 0;
--
To view, visit https://gerrit.osmocom.org/7880
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4401c1139cd01faf5ff374301a9a701898c3777
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
