Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/7960/1/src/gsm/lapdm.c File src/gsm/lapdm.c: Line 545: if (lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM) { May we unpack this condition in the following way: if (lctx->format == LAPD_FORM_U && lctx->s_u == LAPD_U_SABM) { if (le->mode == LAPDM_MODE_BTS) { // ... } else if (le->mode == LAPDM_MODE_MS) { // ... } } Line 708: rc =lapdm_rx_not_permitted(le, &lctx); 's/ =/ = /' -- To view, visit https://gerrit.osmocom.org/7960 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c2c103cdc7f9a45d7b2080c572f559fc3db58e4 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-HasComments: Yes
