Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/7992/1/src/gsup_server.c File src/gsup_server.c: Line 372: msisdn_enc = talloc_size(gsup, OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN); simply OSMO_ASSERT on the talloc result, in all calls (both the one for gsup above, as well as the others here... https://gerrit.osmocom.org/#/c/7992/1/src/luop.c File src/luop.c: Line 53: if (msg_out == NULL) { same here. OSMO_ASSERT(msg_out) is sufficient. -- To view, visit https://gerrit.osmocom.org/7992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865 Gerrit-PatchSet: 1 Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes
