Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/7992 )
Change subject: move creation of insert subscriber data messages to a common function ...................................................................... Patch Set 4: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/7992/4/src/gsup_server.c File src/gsup_server.c: https://gerrit.osmocom.org/#/c/7992/4/src/gsup_server.c@370 PS4, Line 370: * \param[in] msisdn_enc A buffer large enough to store the MSISDN in encoded form. technically that's an [out] param, right? https://gerrit.osmocom.org/#/c/7992/4/src/gsup_server.c@372 PS4, Line 372: * \param[in] apn_buf A buffer large enough to store an APN (required if cn_domain is OSMO_GSUP_CN_DOMAIN_PS). out? https://gerrit.osmocom.org/#/c/7992/4/src/hlr.c File src/hlr.c: https://gerrit.osmocom.org/#/c/7992/4/src/hlr.c@103 PS4, Line 103: peer_len = osmo_gsup_conn_ccm_get(co, &peer, IPAC_IDTAG_SERNR); unrelated change? ... ah no, the diff just makes the re-arrangement hard to spot. -- To view, visit https://gerrit.osmocom.org/7992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865 Gerrit-Change-Number: 7992 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 May 2018 15:17:09 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
