Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/8055 )
Change subject: a_reset: cleanup + remove dead code ...................................................................... Patch Set 2: Code-Review+2 (3 comments) https://gerrit.osmocom.org/#/c/8055/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/8055/2//COMMIT_MSG@11 PS2, Line 11: is started up. Also the timer number is not according to the spec. which timer number is not what according to which spec? https://gerrit.osmocom.org/#/c/8055/2/src/libbsc/a_reset.c File src/libbsc/a_reset.c: https://gerrit.osmocom.org/#/c/8055/2/src/libbsc/a_reset.c@33 PS2, Line 33: #define RESET_RESEND_TIMER_NO 4 /* See also 3GPP TS 48.008 Chapter 3.1.4.1.3.1 */ wow, looks like a double paste typo but the chapter nr is accurate :) https://gerrit.osmocom.org/#/c/8055/2/src/libbsc/a_reset.c@157 PS2, Line 157: reset_fsm = osmo_fsm_inst_alloc(&fsm, NULL, NULL, LOGL_DEBUG, name); (osmo_fsm_inst_alloc() has a priv arg to which you could pass reset_ctx. On the other hand, a good talloc pattern is to allocate the reset_ctx as talloc child of the reset_fsm, so that the deallocating FSM also clears the priv struct at the same time. On the other other hand you say this never gets deallocated. none of these are important, just noting.) -- To view, visit https://gerrit.osmocom.org/8055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72095d52304c520e383755eee6c889bce492cbd4 Gerrit-Change-Number: 8055 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Mon, 14 May 2018 17:50:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
