Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7996 )
Change subject: bsc_api.c: actually log with context ...................................................................... Patch Set 1: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/7996/1/src/libbsc/bsc_api.c File src/libbsc/bsc_api.c: https://gerrit.osmocom.org/#/c/7996/1/src/libbsc/bsc_api.c@47 PS1, Line 47: #define LOGPLCHAN(lchan, ss, level, fmt, args...) \ I think this should go in a header file so it can be used from more code -- To view, visit https://gerrit.osmocom.org/7996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If469defcc6fe8950dac5df61db3f39d297893318 Gerrit-Change-Number: 7996 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 15 May 2018 20:59:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes