Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9202 )

Change subject: use reasonable value if PATH_MAX is not defined
......................................................................


Patch Set 1:

Actually,  I think this ultimately belongs into autoconf:

# Some Unix systems, like Gnu Hurd, don't define PATH_MAX
AC_MSG_CHECKING([for PATH_MAX])
AC_COMPILE_IFELSE( [AC_LANG_PROGRAM([[#include <limits.h>]],
                                    [[char dummy[PATH_MAX];]])],
                   [
                      AC_MSG_RESULT([yes])
                      AC_DEFINE_UNQUOTED([HAVE_PATH_MAX], 1, [Define to 1 if 
you have the PATH_MAX macro.])
                    ],
                    [
                      AC_MSG_RESULT([no])
                      AC_DEFINE_UNQUOTED([HAVE_PATH_MAX], 0, [Define to 1 if 
you have the PATH_MAX macro.])
                    ]
                 )

and then we can have (in a shared header)

#if HAVE_PATH_MAX=0
#define PATH_MAX 4096
#endif


--
To view, visit https://gerrit.osmocom.org/9202
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia884f4c96b4c4eaa1a1be256e3ccda0b4dec4099
Gerrit-Change-Number: 9202
Gerrit-PatchSet: 1
Gerrit-Owner: Thorsten Alteholz <osmo...@alteholz.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-Comment-Date: Thu, 17 May 2018 09:39:50 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to