Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9211 )

Change subject: implement periodic Location Update expiry in the VLR
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9211/2/src/libmsc/subscr_conn.c
File src/libmsc/subscr_conn.c:

https://gerrit.osmocom.org/#/c/9211/2/src/libmsc/subscr_conn.c@211
PS2, Line 211:   * The LU expiry timer will restart once the connection is 
closed. */
do we need an extra field for this?  Doesn't every subscribe with active 
connections have subscr->conn != NULL and we can simply check on that?  It's 
not a strong argument, but if we have the information already somewhere, we 
shouldn't duplicate it.  Or are there other reasons to stop/halt/pause 
expirtation?



--
To view, visit https://gerrit.osmocom.org/9211
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebdee8b12d22acfcfb265ee41e71cfc8d9eb3ba9
Gerrit-Change-Number: 9211
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 12:02:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to