Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9220 )

Change subject: remove redundant unconditional PKG_CHECK_MODULES for libsmpp
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am
File tests/smpp/Makefile.am:

https://gerrit.osmocom.org/#/c/9220/2/tests/smpp/Makefile.am@1
PS2, Line 1: if BUILD_SMPP
It's probably cleaner to move this if to tests/Makefile.am when we add it to 
SUBDIR.



--
To view, visit https://gerrit.osmocom.org/9220
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4a8a5c970c04a6257ee4c8e3977e98c4ddfda13
Gerrit-Change-Number: 9220
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 May 2018 14:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to