Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9214 )

Change subject: nat: Add jitter buffer on the uplink receiver
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h
File include/osmocom/bsc/bsc_nat.h:

https://gerrit.osmocom.org/#/c/9214/1/include/osmocom/bsc/bsc_nat.h@180
PS1, Line 180:  bool bts_use_jibuf;
> I would prefer something like a sub-structure  […]
Makes sense. However, as this commit is just a forward-port from openbsc, I 
think it's better to merge this one as it is, and then do these modification in 
a follow-up commit.



--
To view, visit https://gerrit.osmocom.org/9214
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie07b8a577caf731d59d68e3b3510ae2f9fd3dc93
Gerrit-Change-Number: 9214
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 22 May 2018 09:35:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to