Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/9271 )
Change subject: Implement MNCC Cause <-> SIP Call Error mapping ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/9271/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/9271/1/src/mncc.c@122 PS1, Line 122: > ws, please fix. Yes.. It's a work in progess, not a final patch proposal. https://gerrit.osmocom.org/#/c/9271/1/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/9271/1/src/sip.c@182 PS1, Line 182: other->cause=1; > Do we have any enum or a group of defines for this? Yes, on the way. -- To view, visit https://gerrit.osmocom.org/9271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f9796c8ecdfdd68274e9b32e748d32a4b8dc273 Gerrit-Change-Number: 9271 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 24 May 2018 13:44:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
