Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9269 )
Change subject: Logging: Log mncc_names in mncc_data() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/9269/2/src/mncc_protocol.h File src/mncc_protocol.h: https://gerrit.osmocom.org/#/c/9269/2/src/mncc_protocol.h@199 PS2, Line 199: const char *get_mncc_name(const uint32_t value); > This is not related to this patch? Can this function actually be dropped in this patch? Is it still needed?. -- To view, visit https://gerrit.osmocom.org/9269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I161d1b841ac5fe1b7e092b329ae0674cb340f5ac Gerrit-Change-Number: 9269 Gerrit-PatchSet: 2 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 24 May 2018 14:55:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
