Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/9346 )
Change subject: acc_ramp: Increase log level of some messages
......................................................................
acc_ramp: Increase log level of some messages
Right now, it's impossible to see any ACC Ramping information unless RSL
category is set to DEBUG. Barring and Allowing Access Control Class is
an important event which should be printed in most cases.
Increase log levels of messages printed during some error conditions to
be handled as errors.
Change-Id: I5404e91fe7c0b3209e8033594e659387bbc924d6
---
M src/libbsc/acc_ramp.c
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/libbsc/acc_ramp.c b/src/libbsc/acc_ramp.c
index ff8ff0e..ac9f02d 100644
--- a/src/libbsc/acc_ramp.c
+++ b/src/libbsc/acc_ramp.c
@@ -46,7 +46,7 @@
{
OSMO_ASSERT(acc >= 0 && acc <= 9);
if (acc_ramp->barred_accs & (1 << acc))
- LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: allowing Access
Control Class %u\n", acc_ramp->bts->nr, acc);
+ LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: allowing Access
Control Class %u\n", acc_ramp->bts->nr, acc);
acc_ramp->barred_accs &= ~(1 << acc);
}
@@ -54,7 +54,7 @@
{
OSMO_ASSERT(acc >= 0 && acc <= 9);
if ((acc_ramp->barred_accs & (1 << acc)) == 0)
- LOGP(DRSL, LOGL_DEBUG, "(bts=%d) ACC RAMP: barring Access
Control Class %u\n", acc_ramp->bts->nr, acc);
+ LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP: barring Access
Control Class %u\n", acc_ramp->bts->nr, acc);
acc_ramp->barred_accs |= (1 << acc);
}
@@ -210,7 +210,7 @@
break;
case NM_STATE_NULL:
default:
- LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP:
unrecognized administrative state '0x%x' "
+ LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized
administrative state '0x%x' "
"reported for TRX 0\n", acc_ramp->bts->nr,
nsd->new_state->administrative);
break;
}
@@ -249,7 +249,7 @@
break;
case NM_OPSTATE_NULL:
default:
- LOGP(DRSL, LOGL_NOTICE, "(bts=%d) ACC RAMP:
unrecognized operational state '0x%x' "
+ LOGP(DRSL, LOGL_ERROR, "(bts=%d) ACC RAMP: unrecognized
operational state '0x%x' "
"reported for TRX 0\n", acc_ramp->bts->nr,
nsd->new_state->administrative);
break;
}
--
To view, visit https://gerrit.osmocom.org/9346
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5404e91fe7c0b3209e8033594e659387bbc924d6
Gerrit-Change-Number: 9346
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
