Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9372 )
Change subject: msc/USSD: add single *#100# request testcase ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9372/1/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/9372/1/msc/MSC_Tests.ttcn@2123 PS1, Line 2123: var template PDU_ML3_MS_NW ussd_req := ts_ML3_MO_SS_REGISTER( for "send" templates it is good style to say "template (value)" rather than just "template". This helps the compiler to catch errors at compile time rather than only at runtime. -- To view, visit https://gerrit.osmocom.org/9372 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I82450c6f48f6c17bc33e0ec6c91f2a73e44793ad Gerrit-Change-Number: 9372 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 29 May 2018 19:23:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
