Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/7700 )
Change subject: GSUP: implement TCAP-like session management ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/7700/2/include/osmocom/gsm/gsup.h File include/osmocom/gsm/gsup.h: https://gerrit.osmocom.org/#/c/7700/2/include/osmocom/gsm/gsup.h@197 PS2, Line 197: /*! Unique session identifier and origination flag */ it might make sense to explain that this field (session id) is only valid if session_state != 0 -- To view, visit https://gerrit.osmocom.org/7700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1cee271fed0284a134ffed103c0d4bebbcfde2a8 Gerrit-Change-Number: 7700 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 31 May 2018 13:29:05 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
