Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9471 )
Change subject: WIP: msc/USSD: add multi-transaction testcase ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/9471/1/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/9471/1/msc/MSC_Tests.ttcn@2227 PS1, Line 2227: invoke_id := 5, /* Phone may not start from 0 or 1 */ why always use the same invoke_id? Doesn't that cause problems if you want to use them in parallel? Doesn't the invoke-id need to be unique for a given MS at a given time? https://gerrit.osmocom.org/#/c/9471/1/msc/MSC_Tests.ttcn@2278 PS1, Line 2278: BSSAP.send(ts_dtap_ussd_init_req(tid := 0, code := "*#100#")); interesting approach with the bit-mask and handling everything in a single alt/receive clause below. The more "TTCN native" way to handle this (I believe) would be to create a new component type, where basically each component represents one USSD dialogue/session, and the "BSC_ConnHdlr" dispatches to those individual per-dialogue components based on TID. You can then simply create+start any number of those components in parallel, and wait for them to terminate with verdict success or fail. But I understand that's of course much more effort to implement, so I'm happy to merge the current test. The advantage of the "ussd dialogue component" approach is that in each of those components you then only have to deal with a single dialogue. This method is what we use in e.g. RSL_Emulation to de-multiplex between different logical channels, or in BSSMAP_Emulation to separate the different SCCP connections, ... -- To view, visit https://gerrit.osmocom.org/9471 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifa3cd1aeeb34ccf5864f78b76a88aaa6d5e51839 Gerrit-Change-Number: 9471 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 06 Jun 2018 09:48:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
