Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/9396 )

Change subject: Add debian packaging rules
......................................................................


Patch Set 2:

(2 comments)

I'd keep having only 1 setup.py file. We can have 3 debian packages:

python-osmopy-libs
python-osmopy-scripts
python3-osmopy-libs
python3-osmopy-scripts

Then, to generate it probably something like (not sure if it's the correct way, 
I don't know much about dh debian stuff):

python  setup.py install --install-layout=deb 
--root=$(CURDIR)/debian/python-osmopy-libs
rm -rf $(CURDIR)/debian/python-osmopy-libs/scripts
python  setup.py install --install-layout=deb 
--root=$(CURDIR)/debian/python-osmopy-scripts
rm -rf $(CURDIR)/debian/python-osmopy-libs/osmopy
python3 setup.py install --install-layout=deb 
--root=$(CURDIR)/debian/python3-osmopy-libs
rm -rf $(CURDIR)/debian/python3-osmopy-libs/scripts
python3 setup.py install --install-layout=deb 
--root=$(CURDIR)/debian/python3-osmopy-scripts
rm -rf $(CURDIR)/debian/python3-osmopy-libs/libs

https://gerrit.osmocom.org/#/c/9396/2/debian/control
File debian/control:

https://gerrit.osmocom.org/#/c/9396/2/debian/control@15
PS2, Line 15:  .
Is this dot here expected?


https://gerrit.osmocom.org/#/c/9396/2/debian/control@22
PS2, Line 22:  .
Same here



--
To view, visit https://gerrit.osmocom.org/9396
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: python/osmo-python-tests
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I332fb82d0e8dd09c5cf53caafa6a63297a8e3881
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: Harald Welte <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Thorsten Alteholz <[email protected]>
Gerrit-Comment-Date: Wed, 06 Jun 2018 12:04:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to