Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9474 )
Change subject: protocol: reject illegal multiple lco options ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/9474/1/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/#/c/9474/1/src/libosmo-mgcp/mgcp_protocol.c@406 PS1, Line 406: if (!ptr) I don't understand this code, sorry. * We first get a pointer to the [first] ":" * we then enter the while loop, where we ** check if ptr <= options (which is not true, unless the ":" was the first character) ** we increment ptr, if *ptr is a space or a comma But that increment could never happen, as we only ever enter the while loop with *ptr == ':' What am I missing? btw: these kind of side-effect free functions are the *ideal* candidates for unit tests inside the tests/ subdirectory. https://gerrit.osmocom.org/#/c/9474/1/src/libosmo-mgcp/mgcp_protocol.c@428 PS1, Line 428: int check_local_cx_options(void *ctx, const char *options) this function should have unit test coverage with a variety of legal and illegal strings as input. -- To view, visit https://gerrit.osmocom.org/9474 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae2fddfa5f2bcfc952f8ab217b3056694e5f7812 Gerrit-Change-Number: 9474 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 06 Jun 2018 12:21:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
