Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9552 )
Change subject: Use proper naming for GSM TS 09.11 implementation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h File include/osmocom/msc/ussd.h: https://gerrit.osmocom.org/#/c/9552/1/include/osmocom/msc/ussd.h@a5 PS1, Line 5: > what's your plan for backwards compatibility here? I suggest you keep the old > symbol, mark it as dep […] Hmm, do we really need backwards compatibility here? This header is not being installed to the system include directory, and AFAIK only used by gsm_04_08.c in a single place. This is an internal symbol within the project, so I don't see any reason to keep the old one. Am I wrong? ;) -- To view, visit https://gerrit.osmocom.org/9552 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic1eaceddb58132318e4e941be542da34b8ebefe1 Gerrit-Change-Number: 9552 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Tue, 12 Jun 2018 12:17:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
