Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9624 )
Change subject: lms: Fail in case of unsupported configuration ...................................................................... lms: Fail in case of unsupported configuration There might be some configuration that's not supported by osmo-bts-lms, and we should reject that properly. Change-Id: I6f82edce589030a4407f6150fb7e8abe6417c1f2 Closes: OS#3347 --- M Transceiver52M/device/lms/LMSDevice.cpp 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved Pau Espin Pedrol: Looks good to me, but someone else must approve diff --git a/Transceiver52M/device/lms/LMSDevice.cpp b/Transceiver52M/device/lms/LMSDevice.cpp index 815a4c5..16585e6 100644 --- a/Transceiver52M/device/lms/LMSDevice.cpp +++ b/Transceiver52M/device/lms/LMSDevice.cpp @@ -625,5 +625,13 @@ const std::vector < std::string > &tx_paths, const std::vector < std::string > &rx_paths) { + if (tx_sps != rx_sps) { + LOG(ERROR) << "LMS Requires tx_sps == rx_sps"; + return NULL; + } + if (lo_offset != 0.0) { + LOG(ERROR) << "LMS doesn't support lo_offset"; + return NULL; + } return new LMSDevice(tx_sps, rx_sps, iface, chans, lo_offset, tx_paths, rx_paths); } -- To view, visit https://gerrit.osmocom.org/9624 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6f82edce589030a4407f6150fb7e8abe6417c1f2 Gerrit-Change-Number: 9624 Gerrit-PatchSet: 3 Gerrit-Owner: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>