Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/9663 )
Change subject: ms: Use the new API to pass credentials to the event server ...................................................................... Patch Set 1: > I don't really understand the purpose of this commit. You seem to > be changing code to use recvmsg to get the sender address, but then > I only see you are passing the address and doing nothing useful > with it. What this will give us: * Bi-directional communication between mobile and the testcase * By using autobind not having to pick a unique filename It's true that the test is not making use of it at all. Bi-directional communication will be needed to implement your idea of a o-fono like interface (without having to have 10k connections). > Then, you start using this new API unix_passcred, which enables > being able to send credentials over the socket (not sending them), > but I don't see any new code or changed code actually sending the > credentials. The side-effect of this socket option is the autobinding. If one commentt it out then the event_server will get 'None' as remote address. -- To view, visit https://gerrit.osmocom.org/9663 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9b9ac6267f40345baf7dbb3becaecf264a5df5f Gerrit-Change-Number: 9663 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 18 Jun 2018 19:29:58 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
