Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9683 )
Change subject: msc/USSD: drop the TC_lu_and_ussd_wrong_code test case ...................................................................... Patch Set 1: > I'm not sure this test should be dropped. Rather, the test should > be adapted to simulate the HLR part which then rejects/denies the > USSD code. Even if we simulate the Reject coming from HLR via GSUP, this test case would merely duplicate the existing TC_lu_and_mo_ussd_single_request. >From the OsmoMSC point of view, there is no difference, which kind of GSM 04.80 payload (Invoke, ReturnResult or Reject components) is being forwarded. This test case is only actual for the current OsmoMSC implementation, which handles the SS/USSD itself. -- To view, visit https://gerrit.osmocom.org/9683 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic104a49bb2dce2127063bcef8443ee6b639c9f19 Gerrit-Change-Number: 9683 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-Comment-Date: Wed, 20 Jun 2018 10:53:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
