Harald Welte has posted comments on this change. (
https://gerrit.osmocom.org/9668 )
Change subject: fix / clarify rsl dtap cache
......................................................................
Patch Set 3:
(3 comments)
as all RSL messages at all time now seem to pass thorugh some of the code, the
logging ("DHO") will need to be reconsidered/modified.
https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h
File include/osmocom/bsc/gsm_data.h:
https://gerrit.osmocom.org/#/c/9668/3/include/osmocom/bsc/gsm_data.h@123
PS3, Line 123: struct llist_head dtap_cache;
unrelated to this patch: I think "cache" is a misnomer. It' s simply a queue.
A "cache" is something you keep for subsequent lookups, not simply something
you're queueing.
https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c
File src/osmo-bsc/bsc_subscr_conn_fsm.c:
https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1125
PS3, Line 1125: 23
no #define? 23 seems like a lot, btw.
https://gerrit.osmocom.org/#/c/9668/3/src/osmo-bsc/bsc_subscr_conn_fsm.c@1126
PS3, Line 1126: DHO
why do we log this in DHO, if it's now a generic functionality?
--
To view, visit https://gerrit.osmocom.org/9668
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ffd7aa641c8905292c769400048c96aa0949585
Gerrit-Change-Number: 9668
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <[email protected]>
Gerrit-Comment-Date: Fri, 22 Jun 2018 15:20:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
