Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/9682 )
Change subject: library/L3_Templates.ttcn: fix f_facility_or_wc(omit) ...................................................................... library/L3_Templates.ttcn: fix f_facility_or_wc(omit) According to GSM TS 04.80, table 2.5, the Facility IE is optional for RELEASE COMPLETE message. So, if this IE is omitted, then the whole TVL shall be omitted. It's time to fix this. Change-Id: I216195ef71c95997708dad8c31b172b6f6cdc461 --- M library/L3_Templates.ttcn 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified Harald Welte: Looks good to me, approved diff --git a/library/L3_Templates.ttcn b/library/L3_Templates.ttcn index d0f1406..9d6d3c3 100644 --- a/library/L3_Templates.ttcn +++ b/library/L3_Templates.ttcn @@ -1332,6 +1332,8 @@ return *; } else if (istemplatekind(facility, "?")) { return ?; + } else if (istemplatekind(facility, "omit")) { + return omit; } else { return tr_FacTLV(facility); } -- To view, visit https://gerrit.osmocom.org/9682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I216195ef71c95997708dad8c31b172b6f6cdc461 Gerrit-Change-Number: 9682 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder