Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9711 )

Change subject: libmsc/gsm_09_11.c: introduce rate counters for NC_SS sessions
......................................................................


Patch Set 1:

you are basically referring to two different bits of information:

a) the *rate* of events (ussd requests) over time
and
b) the currently active number of sessions. That's what some monitoring systems 
call a "gauge".

Only "a)" can be implemented as a rate_ctr.  I *think* stat_items can do the 
"gauge"?  In any case, we can merge this current patch as-is. as it implements 
"a)". If somebody wants a "b)" patch later, fine.


--
To view, visit https://gerrit.osmocom.org/9711
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23c9475abc9951d82f3342fdc5aaa367836f7741
Gerrit-Change-Number: 9711
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Alexander Chemeris <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Mon, 25 Jun 2018 10:51:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to