Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9781 )
Change subject: rsl: use 3GPP assigned payload type numbers ...................................................................... Patch Set 1: RSL is part of Abis. the 3GPP payload types apply to the A interface only. So in principle, there is no need for us to use the A interface PT definitions on Abis. osmo-mgw should be able to detect that the same codec is used on two connections, but that the PT doesn't agree, and then patch/rewrite the PTs according to the rtpmap of both connections. The existing dynamic PT definitions for Abis were used this way to align with what ip.access is doing on the Abis/IP interface. However, since it's configurable via RSL CRCX / MDCX, I think it sould be find to change this. However, we should double-check that it works with nanoBTS. Also, irrespective of whether we change it here or not, we should make sure osmo-mgw does the PT translation between different connections. This is important *particularly* also with the MSC-colocated MGW where the PT on the external (SIP) side is determined by a remote peer, and that peer of course has [rightfully] no clue about what 3GPP AoIP specs might say. -- To view, visit https://gerrit.osmocom.org/9781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6a866b29d863d6875c67748dbe6b6468941ab29 Gerrit-Change-Number: 9781 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 29 Jun 2018 17:47:20 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
