Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9780 )
Change subject: rtp: use 3GPP assigned payload type numbers ...................................................................... Patch Set 1: rather than doing search/replace in three locations (libosmo-abis, libosmo-netif and osmo-bsc.git), we should make sure that we only have one place for #define of those values, and then use it from everywhere. And if we keep multiple, they should not have the same names in the global namespace of preprocessor #defines. For sure the osmo-bsc.git ones should go, and the libosmo-abis ones used in osmo-bsc. For libosmo-netif, the problem is that it doesn't depend on libosmo-abis, and sharing the definitions would introduce a related dependency. -- To view, visit https://gerrit.osmocom.org/9780 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9ea525a615685c4b2369e491db46452b63c6cb Gerrit-Change-Number: 9780 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 29 Jun 2018 17:51:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
