Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9653 )

Change subject: introduce a TTCN3 test suite for SCCP
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh
File sccp/gen_links.sh:

https://gerrit.osmocom.org/#/c/9653/2/sccp/gen_links.sh@56
PS2, Line 56: FILES+="MNCC_Types.ttcn MNCC_EncDec.cc MNCC_CodecPort.ttcn mncc.h 
MNCC_Emulation.ttcn "
where is MNCC used in this testsuite? I commented on its removal in my previous 
review.  Maybe thre is some dependency that I'm not aware of? If so, please 
explain. Thanks!



--
To view, visit https://gerrit.osmocom.org/9653
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I03f5e8b282a7396b45417495c88d8fb81b26cda8
Gerrit-Change-Number: 9653
Gerrit-PatchSet: 2
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Comment-Date: Fri, 06 Jul 2018 14:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Reply via email to