Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9959 )

Change subject: sua: Export IEI value_string names
......................................................................


Patch Set 1: Code-Review-1

it seems the intention of the API is to have IEI name definitions based on the 
xua_msg_type, so that the IEIs can differ based on the underlying transport 
layer. Publishing sua_iei_names bypasses the apparently carefully crafted API 
to avoid exactly that. (See where sua_iei_names gets used)


--
To view, visit https://gerrit.osmocom.org/9959
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b34eaa2cb4109879324dc9ba6c7dacd53b1a28f
Gerrit-Change-Number: 9959
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jul 2018 13:53:30 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to