Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9956 )

Change subject: fix two memleaks in ipa_rx_msg_sccp()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9956/1/src/ipa.c
File src/ipa.c:

https://gerrit.osmocom.org/#/c/9956/1/src/ipa.c@268
PS1, Line 268:  xua_msg_free(xua);
> Shouldn't upper layers be owning and thus freeing the message?
this is the uppermost layer: the xua_msg gets allocated in 
m3ua_xfer_from_data() above. (maybe you're mixing it up with the msgb? that 
also gets freed here, and is unrelated to the patch)



--
To view, visit https://gerrit.osmocom.org/9956
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0918f9bbc15b036619f1c25a133b69819b2a30fa
Gerrit-Change-Number: 9956
Gerrit-PatchSet: 1
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jul 2018 14:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to