Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/9958 )

Change subject: comment: explain xua_msg free in m3ua_rx_xfer()
......................................................................


Patch Set 2:

re free policy: with struct xua_msg, throughout the code, the function that 
creates the struct xua_msg also frees it. (with a few exceptions that seem 
erratic and are being fixed by these patches.)

If the lower layers had to free the xua_msg, each and every error handling code 
path would need an explicit xua_msg_free(). The xua_msg is never enqueued 
anywhere, it merely exists to pass a message down a code path.


--
To view, visit https://gerrit.osmocom.org/9958
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6211c8809eefeb94289c4c497553561b043ee619
Gerrit-Change-Number: 9958
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Wed, 11 Jul 2018 14:43:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to