Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9953 )
Change subject: add osmo_xua_msg_tall_ctx_init() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) let's please remove the misleading part from the commitlog message. thanks! https://gerrit.osmocom.org/#/c/9953/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/9953/1//COMMIT_MSG@16 PS1, Line 16: The convention should actually be that only libosmocore exposes API with the : osmo_ prefix, but libosmo-sigtran explicitly exposes only symbols starting with : osmo_, forcing me to use this prefix. this is not correct. All libosmo* may expose API with osmo_ prefix. -- To view, visit https://gerrit.osmocom.org/9953 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I618878680a096a7f7fc2d83098590f2e4cb08870 Gerrit-Change-Number: 9953 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 11 Jul 2018 20:03:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
