Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9979 )
Change subject: nat: ctrl: use strtol instead of atoi as it has explicit error documentation ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9979/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c File openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c: https://gerrit.osmocom.org/#/c/9979/1/openbsc/src/osmo-bsc_nat/bsc_nat_ctrl.c@89 PS1, Line 89: int id = (long int) strtol(id_str, &endptr, 10); > according to my man, strol() returns long int. […] Sorry my bad, I wanted to cast to (int) since it's intended to get an int and avoid a compiler warning. -- To view, visit https://gerrit.osmocom.org/9979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief0b203efbcf2be04253b5056840be94d58a9994 Gerrit-Change-Number: 9979 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jul 2018 18:16:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
