Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/9982 )
Change subject: ctrl: Avoid sending back received ERROR msgs ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9982/1/src/osmo-bsc/osmo_bsc_ctrl.c File src/osmo-bsc/osmo_bsc_ctrl.c: https://gerrit.osmocom.org/#/c/9982/1/src/osmo-bsc/osmo_bsc_ctrl.c@123 PS1, Line 123: if (cmd->type == CTRL_TYPE_ERROR && parse_failed) > (parse_failed always comes with CTRL_TYPE_ERROR, right?) Yes, API wise only makes sense if cmd->type=ERROR is returned. -- To view, visit https://gerrit.osmocom.org/9982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If0cd4d435acd13dd132248c521e6bb0182de0deb Gerrit-Change-Number: 9982 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Jul 2018 18:47:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
