Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/9996 )
Change subject: coding: Always initialize bit counters in gsm0503_pdtch_egprs_decode(). ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/9996/1/src/coding/gsm0503_coding.c File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/#/c/9996/1/src/coding/gsm0503_coding.c@942 PS1, Line 942: if (n_bits_total) *n_bits_total = 0; Do we also initialize both variables on other decoding functions? And why not to initialize both by caller? -- To view, visit https://gerrit.osmocom.org/9996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4722cae3794ccbb12001113c991d9cf345a52a96 Gerrit-Change-Number: 9996 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Chemeris <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sun, 15 Jul 2018 11:31:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
