Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10004 )

Change subject: MSC_ConnectionHandler: more verbosity for 
f_check_mgcp_expectations()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/10004/1/bsc/MSC_ConnectionHandler.ttcn
File bsc/MSC_ConnectionHandler.ttcn:

https://gerrit.osmocom.org/#/c/10004/1/bsc/MSC_ConnectionHandler.ttcn@797
PS1, Line 797: function f_check_mgcp_expectations(charstring caller) runs on 
MSC_ConnHdlr {
rather than explicitly passing a hand-written string as function argument, you 
could possibly use "testcasename()" which always expands to the name of the 
currently running testcase.  However, this may not be what you actually want 
here, in case the function is called via different paths during the same test 
case.



--
To view, visit https://gerrit.osmocom.org/10004
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida0eba4ef3c1db977d392267ef76ec37b87133b3
Gerrit-Change-Number: 10004
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Harald Welte <[email protected]>
Gerrit-Comment-Date: Mon, 16 Jul 2018 17:40:57 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to