Pau Espin Pedrol has uploaded this change for review. (
https://gerrit.osmocom.org/10019
Change subject: sgsn: gtp: Avoid leaking pdp ctx in libgtp
......................................................................
sgsn: gtp: Avoid leaking pdp ctx in libgtp
Nowadays sgsn_pdp_ctx_free() takes care of freeing the underlaying gtp
object if available. Don't bypass this check, as libgtp
sgsn_pdp_ctx_free() doesn't free the pdp ctx obj after the osmo-sgsn
cb_conf callback is called, so it needs to be freed with pdp_freepdp.
Change-Id: I304c59de5d137b81de3c6df0fdbe911ae3dbd1f3
---
M src/gprs/sgsn_libgtp.c
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/19/10019/1
diff --git a/src/gprs/sgsn_libgtp.c b/src/gprs/sgsn_libgtp.c
index 659392e..6d5b9df 100644
--- a/src/gprs/sgsn_libgtp.c
+++ b/src/gprs/sgsn_libgtp.c
@@ -566,10 +566,6 @@
"is not available\n");
}
- /* unlink the now non-existing library handle from the pdp
- * context */
- pctx->lib = NULL;
-
sgsn_pdp_ctx_free(pctx);
return rc;
--
To view, visit https://gerrit.osmocom.org/10019
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I304c59de5d137b81de3c6df0fdbe911ae3dbd1f3
Gerrit-Change-Number: 10019
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
