Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/10020 )
Change subject: Revert "Move from libc random() to osmo_get_rand_id" ...................................................................... Patch Set 2: Code-Review+2 This is something I didn't consider. What's the bigger picture is that if we don't want negative numbers. We shouldn't store the result in a signed variable. But it might be easier to to just & ~0x7F...and return ints from 0 to ... N. Feel free to push the revert and I will try to have a timely fix. -- To view, visit https://gerrit.osmocom.org/10020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7b2a8a5c63cf64360a824926a2219fd7e419b1bb Gerrit-Change-Number: 10020 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 16 Jul 2018 23:36:45 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
