Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/10005 )
Change subject: MSC_ConnectionHandler: expect additional MDCX when call is LCLS
......................................................................
MSC_ConnectionHandler: expect additional MDCX when call is LCLS
The function f_establish_f_establish_fully does not yet handle the
case where calls get switched locally. In those cases we expect to
see one additional MDCX before the BSSMAP ASSIGNMENT COMPLETE is
sent.
- Check exp_ass_cpl if the call is expected to be LCLS and expect
another MDCX for those cases.
Change-Id: I55fae5ab03980cd810ed7dc38208550686b1659e
Related: OS#3292
---
M bsc/MSC_ConnectionHandler.ttcn
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
Harald Welte: Looks good to me, approved
diff --git a/bsc/MSC_ConnectionHandler.ttcn b/bsc/MSC_ConnectionHandler.ttcn
index ba4d19d..94cd9ef 100644
--- a/bsc/MSC_ConnectionHandler.ttcn
+++ b/bsc/MSC_ConnectionHandler.ttcn
@@ -947,6 +947,18 @@
self.stop;
}
+ /* When the BSC detects that LCLS is possible it will cross the
+ * connetions that point to the PBX side of the MGW. In our case this
+ * is mgcp_conn[1]. The BSC performs this operation already before the
+ * assignment complete is generated. This means we expect another MDCX
+ * at mgcp_conn[1] when LCLS is expected. */
+ if
(ispresent(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue))
{
+ if
(valueof(exp_ass_cpl.pdu.bssmap.assignmentComplete.lCLS_BSS_Status.lCLS_BSS_StatusValue)
== LCLS_STS_locally_switched) {
+ g_media.mgcp_conn[1].mdcx_seen_exp :=
g_media.mgcp_conn[1].mdcx_seen_exp + 1;
+
+ }
+ }
+
f_check_mgcp_expectations();
}
--
To view, visit https://gerrit.osmocom.org/10005
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I55fae5ab03980cd810ed7dc38208550686b1659e
Gerrit-Change-Number: 10005
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
