Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10028 )
Change subject: fix unaligned access in build_ipcp_pco() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c File ggsn/ggsn.c: https://gerrit.osmocom.org/#/c/10028/1/ggsn/ggsn.c@514 PS1, Line 514: ipcp = (struct pco_ipcp_hdr *)pco_contains_proto(&pdp->pco_req, PCO_P_IPCP); So we increased size of the struct prepending bytes, but we still pass same pointer here and didn't change implementation of that function? This smells being wrong. -- To view, visit https://gerrit.osmocom.org/10028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia75ee0f64e660f6ff6d81d808f9c460b7cac93d2 Gerrit-Change-Number: 10028 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 15:13:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
