lynxis lazus has uploaded this change for review. ( 
https://gerrit.osmocom.org/10032


Change subject: vty: initialize termios before using it
......................................................................

vty: initialize termios before using it

valgrind complains about using unitialised bytes in syscalls.
I could imagine this happens when tcgetattr fails to set termios.

Change-Id: I9d165911fa3127afa8f836fa5c5c2e14a949474a
---
M src/vty/vty.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/32/10032/1

diff --git a/src/vty/vty.c b/src/vty/vty.c
index 08258e7..4d5ffea 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1506,7 +1506,7 @@
 {
   struct vty *vty;

-       struct termios t;
+       struct termios t = { 0 };

        tcgetattr(vty_sock, &t);
        cfmakeraw(&t);

--
To view, visit https://gerrit.osmocom.org/10032
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d165911fa3127afa8f836fa5c5c2e14a949474a
Gerrit-Change-Number: 10032
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <[email protected]>

Reply via email to