dexter has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9986 )

Change subject: cards: return SW in method update_plmnsel() of class Card
......................................................................

cards: return SW in method update_plmnsel() of class Card

The method update_plmnsel() does not return the status word yet, which
causes pysim-prog.py to print an error message that does not influence
the functionality but does not look nice.

- preserve the status word that is returned with update_binary() and
  return it properly like the other methods do.

Change-Id: I54e8e165f87365e8162b36d24efc8f0db62b66da
Related: SYS#4245
---
M pySim/cards.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  dexter: Verified



diff --git a/pySim/cards.py b/pySim/cards.py
index 9be04ff..a72a52f 100644
--- a/pySim/cards.py
+++ b/pySim/cards.py
@@ -87,7 +87,8 @@
                data = self._scc.read_binary(EF['PLMNsel'], length=None, 
offset=0)
                 size = len(data[0])/2
                hplmn = enc_plmn(mcc, mnc)
-               self._scc.update_binary(EF['PLMNsel'], hplmn + 'ff' * (size-3))
+               data, sw = self._scc.update_binary(EF['PLMNsel'], hplmn + 'ff' 
* (size-3))
+               return sw

        def update_smsp(self, smsp):
                data, sw = self._scc.update_record(EF['SMSP'], 1, rpad(smsp, 
84))

--
To view, visit https://gerrit.osmocom.org/9986
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I54e8e165f87365e8162b36d24efc8f0db62b66da
Gerrit-Change-Number: 9986
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>

Reply via email to