Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/7711 )
Change subject: MNCC: don't delete calls, provide del signature ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/7711/1/library/MNCC_Emulation.ttcn File library/MNCC_Emulation.ttcn: https://gerrit.osmocom.org/#/c/7711/1/library/MNCC_Emulation.ttcn@297 PS1, Line 297: /* MNCC -> Client: Release Indication / confirmation */ looking at this again; I now notice that it is not even required to send a REL_CNF back to osmo-msc after the REL_IND. The log merely says "Received 'MNCC_REL_CNF' from MNCC with unknown callref -2147483643". So the entire reason for me to implement this was moot from the start. Even though the motivation to follow through on it is pretty much gone now, for completeness' sake: I got the signature on the procedure port implemented ok and it seems to be working. I'm a bit lost on where to call it from: at the end of every test that has "MNCC" appearing in it? Different idea: when receiving an MNCC REL_IND, should we actually reply with a REL_CNF here before we (still do) delete the call table entry automatically? (putting this patch on ice for now) -- To view, visit https://gerrit.osmocom.org/7711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73ec066744475d3cc464e34854175f8cf14cf125 Gerrit-Change-Number: 7711 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 19 Jul 2018 23:40:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
