Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/10073 )

Change subject: libosmocodec: FR err concealment: Fix too many silent frames 
generated
......................................................................


Patch Set 1: Code-Review+1

You have fixed this, but the test results didn't even change...
Looks like this part of code is out of the unit test coverage.
May we cover this part somehow?


--
To view, visit https://gerrit.osmocom.org/10073
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1624b7c6574f53d0593a61645d4fdc5d56cabe96
Gerrit-Change-Number: 10073
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Comment-Date: Fri, 20 Jul 2018 15:26:15 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to