Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10098 )
Change subject: Move from libc random() to osmo_get_rand_id (2nd attempt) ...................................................................... Patch Set 3: (3 comments) https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/gsm48_mm.c File src/host/layer23/src/mobile/gsm48_mm.c: https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/gsm48_mm.c@33 PS3, Line 33: #include <osmocom/gsm/gsm_utils.h> This include is not required. https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/gsm48_rr.c File src/host/layer23/src/mobile/gsm48_rr.c: https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/gsm48_rr.c@74 PS3, Line 74: #include <osmocom/gsm/gsm_utils.h> This include is not required. https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/settings.c File src/host/layer23/src/mobile/settings.c: https://gerrit.osmocom.org/#/c/10098/3/src/host/layer23/src/mobile/settings.c@26 PS3, Line 26: #include <osmocom/gsm/gsm_utils.h> This include is not required. -- To view, visit https://gerrit.osmocom.org/10098 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdd4be88c62bba1e9d954568e48f0c12a67ac182 Gerrit-Change-Number: 10098 Gerrit-PatchSet: 3 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 23 Jul 2018 19:46:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
