Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/9669 )
Change subject: move RSL and RR related functions to abis_rsl.[hc] ...................................................................... Patch Set 12: > Maybe it makes more sense to move some of those out. I think > "_utils" still is a misnomer for the central Abis RR > implementation, could become abis_rr.c, but we don't really need to > rename the file. I agree, and I wouldn't mind the rename either. However, it's not "Abis RR", but "gsm0408_rr". Afte rall, RR is a Layer3 sub-layer spoken over Abis and Um. See also my recently-proposed patch to move the CC related 04.08 messages to a separate file in osmo-msc. > Then there is bsc_api.c, that appears to have been a kitchen sink > for everything and anything. We removed struct bsc_api already. Do > we agree on moving bsc_api.c's RR functions? yes, I would be more than happy with that. > If gsm_04_08_utils.c > is the main "RR" file, then maybe handle_rr_ho_*() and > gsm_04_08_rcvmsg should move from bsc_api.c to gsm_04_08_utils.c > instead of abis_rsl.c? ACK > (The only functions left in bsc_api.c are gsm0808_page() and > gsm0808_cipher_mode(), maybe they can move to the callers, paging.c > and osmo_bsc_bssap.c, to completely drop bsc_api.c) great! -- To view, visit https://gerrit.osmocom.org/9669 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8ee334145bf7bc3a601d395ea7ab9b2009b61c7 Gerrit-Change-Number: 9669 Gerrit-PatchSet: 12 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 05:13:03 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
