daniel has posted comments on this change. ( https://gerrit.osmocom.org/9905 )
Change subject: library: Ensure setverdict(fail is followed by mtc.stop ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn File library/BSSGP_Emulation.ttcn: https://gerrit.osmocom.org/#/c/9905/1/library/BSSGP_Emulation.ttcn@291 PS1, Line 291: testcase.stop("Client Table full"); > Why do you use testcase.stop instead of setverdict(fail) + mtc. […] testcase.stop will mark the testcase as error so I tried using that for internal errors of our test infrastructure. I updated the commit message to clarify. https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn File library/Osmocom_Types.ttcn: https://gerrit.osmocom.org/#/c/9905/1/library/Osmocom_Types.ttcn@98 PS1, Line 98: setverdict(fail, "Unsupported template", inp); > I'd say this one cannot be reached, so we can drop it. Done -- To view, visit https://gerrit.osmocom.org/9905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc6819aaf0b01e70c38fad828dd44dcec6bdd778 Gerrit-Change-Number: 9905 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 07:59:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
