Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10126 )
Change subject: jobs: osmo-gsm-tester-builder: Fix typo in job parameter name ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/10126/1/jobs/osmo-gsm-tester-builder.yml File jobs/osmo-gsm-tester-builder.yml: https://gerrit.osmocom.org/#/c/10126/1/jobs/osmo-gsm-tester-builder.yml@82 PS1, Line 82: name: OSMO_GSM_TESTER_BUILD_osmo-mgw but shouldn't this say "osmo_mgw" because dashes are not allowed in env var names? i.e. you replaced the wrong osmo_mgw? -- To view, visit https://gerrit.osmocom.org/10126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ab7f8796b8b78d5f21b7a4f541fd3ddffc95a4 Gerrit-Change-Number: 10126 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 24 Jul 2018 10:20:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
